Skip to content

Use RenderStartup for atmosphere rendering. #20186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use RenderStartup for atmosphere rendering. #20186

wants to merge 2 commits into from
+302 −283

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

Testing

  • Ran the atmosphere example and it worked!

@andriyDev andriyDev requested review from atlv24 and IceSentry July 18, 2025 08:22
@andriyDev andriyDev added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 18, 2025
@nicopap nicopap self-requested a review July 18, 2025 09:22
nicopap
nicopap suggested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears you forgot to push the changes that fix the missing atmosphere. (I know they exist, I saw you write them)

As is, the atmosphere doesn't render.

@andriyDev andriyDev force-pushed the startup-atmosphere branch from 557f087 to cd380aa Compare July 18, 2025 16:39
@andriyDev
Copy link
Contributor Author

Ah yep, thanks! Fix is now in!

@andriyDev andriyDev requested a review from nicopap July 18, 2025 16:42
nicopap
nicopap approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atlv24 atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 20, 2025
@andriyDev andriyDev added S-Blocked This cannot move forward until something else changes and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 20, 2025
@andriyDev
Copy link
Contributor Author

Blocking on #20206.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlv24 atlv24 atlv24 approved these changes

@nicopap nicopap nicopap approved these changes

@IceSentry IceSentry Awaiting requested review from IceSentry

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Blocked This cannot move forward until something else changes
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriyDev @atlv24 @nicopap